Skip to content

(fix) adjust menubar hotkey detection (Alt) for Qt 6.9 #15352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

(fix) adjust menubar hotkey detection (Alt) for Qt 6.9 #15352

merged 1 commit into from
Sep 22, 2025

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Sep 13, 2025

Fixes #15350

With Qt < 6.9 Alt press was reporte as Alt(modifier) + Qt::Key_Alt, now it's just the latter.

@Swiftb0y

@ronso0 ronso0 added this to the 2.5.4 milestone Sep 13, 2025
@ronso0 ronso0 mentioned this pull request Sep 13, 2025
Open
Swiftb0y
Swiftb0y approved these changes Sep 13, 2025
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thank you. No regressions on your side too?

@ronso0
Copy link
Member Author

ronso0 commented Sep 13, 2025

Yup, still working.
getKeySeq has already been looking for key = Alt, so no issues to be expected 🥸

@ronso0
Copy link
Member Author

ronso0 commented Sep 13, 2025

maybe @JoergAtGithub @Eve00000 can test on Windows just to be sure?

@JoergAtGithub
Copy link
Member

I can only test with Qt6.8

@ronso0
Copy link
Member Author

ronso0 commented Sep 13, 2025

That would help to verify nothing is broken on Qt < 6.9

Though, we can also wrap it in #ifdef Qt >=6.9

@JoergAtGithub
Copy link
Member

I don't see a difference between 2.5 and this PR - both with Qt 6.5.3.
But I noticed that the menu toggle only works reliable after restarting Mixxx once. Immediately after setting the checkbox in the View menu, ALT just hides the menu, but can not show it. This happens in both cases.

@ronso0
Copy link
Member Author

ronso0 commented Sep 20, 2025

Okay. (not)
Can you please file an issue so we don't forget about it?

@JoergAtGithub
Copy link
Member

Can you please file an issue so we don't forget about it?

#15385

@ronso0
Copy link
Member Author

ronso0 commented Sep 22, 2025

#15385 is fixed by #15396

@ronso0
Copy link
Member Author

ronso0 commented Sep 22, 2025

So shall we merge this?

@JoergAtGithub
Copy link
Member

Ok, Thank you!

@JoergAtGithub JoergAtGithub merged commit e039c67 into mixxxdj:2.5 Sep 22, 2025
13 checks passed
@ronso0 ronso0 deleted the menubar-fix-for-Qt6.9 branch September 22, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
controller backend
Projects
None yet
Milestone
2.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ronso0 @JoergAtGithub @Swiftb0y